From e3c600cbbf5b0ca09f9c0d66e7a212dd46b36a4a Mon Sep 17 00:00:00 2001
From: Akihiro Motoki <amotoki@gmail.com>
Date: Sat, 11 May 2019 10:38:40 +0900
Subject: [PATCH] Add relnote on cinderclient minver bump to 4.0.1

A fix for bug 1824017 bumped the minimum version requirement of
python-cinderclient to 4.0.0. The fix was backported to stable/stein,
so the minimum version bump should be covered by a release note.

python-cinderclient requirement is bumped to >=4.0.1
as 4.0.0 is blocked by global-requirements.txt [1].

It was suggested by the release team in the review of
horizon stein update release [2].

[1] https://opendev.org/openstack/requirements/src/commit/1baf07a77333fc57d9d4a669d0265b0e687fd031/global-requirements.txt#L256
[2] https://review.opendev.org/#/c/655447/

Change-Id: I2b43e159da7e58980b2810a104ae2418f237d1c7
Related-Bug: #1824017
---
 lower-constraints.txt                                  |  2 +-
 ...stein-cinderclient-dependency-9e12a69492f63289.yaml | 10 ++++++++++
 requirements.txt                                       |  2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 releasenotes/notes/stein-cinderclient-dependency-9e12a69492f63289.yaml

diff --git a/lower-constraints.txt b/lower-constraints.txt
index 23c13a2f01..caea19b032 100644
--- a/lower-constraints.txt
+++ b/lower-constraints.txt
@@ -92,7 +92,7 @@ pyOpenSSL==17.1.0
 pyparsing==2.1.0
 pyperclip==1.5.27
 pyScss==1.3.4
-python-cinderclient==4.0.0
+python-cinderclient==4.0.1
 python-dateutil==2.5.3
 python-glanceclient==2.8.0
 python-keystoneclient==3.15.0
diff --git a/releasenotes/notes/stein-cinderclient-dependency-9e12a69492f63289.yaml b/releasenotes/notes/stein-cinderclient-dependency-9e12a69492f63289.yaml
new file mode 100644
index 0000000000..67391fe35c
--- /dev/null
+++ b/releasenotes/notes/stein-cinderclient-dependency-9e12a69492f63289.yaml
@@ -0,0 +1,10 @@
+---
+upgrade:
+  - |
+    python-cinderclient ``>=4.0.1`` is now required to fix :bug:`1824017`.
+    Cinder API 3.55 or later does not accept additional properties but
+    python-cinderclient older than 4.0.0 sends additional properties like
+    used_id, status and so on. Horizon uses Cinder API 3.58 to create a volume,
+    and this means the volume creation fails if python-cinderclient <4.0.0
+    is used. To handle this, the minimum requirement of python-cinderclient
+    was bumped to 4.0.1.
diff --git a/requirements.txt b/requirements.txt
index 215719ad58..2c907d8da8 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -31,7 +31,7 @@ osprofiler>=2.3.0 # Apache-2.0
 Pint>=0.5 # BSD
 pymongo!=3.1,>=3.0.2 # Apache-2.0
 pyScss!=1.3.5,>=1.3.4 # MIT License
-python-cinderclient>=4.0.0 # Apache-2.0
+python-cinderclient>=4.0.1 # Apache-2.0
 python-glanceclient>=2.8.0 # Apache-2.0
 python-keystoneclient>=3.15.0 # Apache-2.0
 python-neutronclient>=6.7.0 # Apache-2.0
-- 
GitLab