Skip to content
Snippets Groups Projects
  1. Apr 01, 2019
    • Eric Desrochers's avatar
      Not implicitly set vol_device_name to vda · eba87483
      Eric Desrochers authored
      Using a scsi decorated image with:
      hw_disk_bus='scsi'
      hw_scsi_model='virtio-scsi'
      
      This solve the case where an instance is
      launched with 'image' selected as boot
      source with a new volume. This will result
      in /dev/vda instead of /dev/sda as it
      should.
      
      Not specifying device name in
      setFinalSpecBootImageToVolume() leaves the
      decision to nova to determine it.
      
      Example:
      -------
      VM boot volume without scsi meta data decoration:
      Attached To
      0a0cd660-7ce3-4033-9983-2e1099edc5f0 on /dev/vda
      
      VM boot volume with scsi meta data decoration:
      Attached To
      91f50dbc-8bdf-4293-84ea-fc5df27b5ee4 on /dev/sda
      --------
      
      Note: This commit doesn't address cases for
      where instances are launched using existing
      volume and snapshot, this will involve more
      work to migrate the code from BDMv1 to BDMv2.
      
      Closes-Bug #1560965
      
      Change-Id: I9d114c2c2e6736a8f1a8092afa568f930b656f09
      (cherry picked from commit 0df60f4d)
      2 tags
      eba87483
  2. Mar 27, 2019
    • Akihiro Motoki's avatar
      network topology: handle port AZ correctly · a729170c
      Akihiro Motoki authored
      Previously d3 version of the network topology view handles ports with
      device_owner 'compute:nova' and 'compute:None' specially. This leads
      to the situtaion that neutron ports with non-default AZ are not shown
      properly. There is no reason to handle neutron ports with the default
      AZ differently. What we would like to do is just to classify neutron
      ports attached to nova servers.
      
      This commit changes the logic to check device_owner of ports have
      a prefix 'compute:'. Note that we also need to check if device_owner
      is a string before checking the prefix.
      
      Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
      Closes-Bug: #1820260
      (cherry picked from commit ffbe0e2f)
      a729170c
  3. Feb 03, 2019
    • jmoffitt's avatar
      Consistency Group Snapshots detail url is wrong · ca1e8f77
      jmoffitt authored
      The link in the consistency group table for "detail" is a mismatch
      for the corresponding value in the urls.py file, causing cg snapshots
      clicks to not load details for the user.
      
      This bug was introduced in https://review.openstack.org/#/c/429506
      where the link in tables.py was changed from:
      "horizon:project:volumes:cg_snapshots:cg_snapshot_detail"
      to
      "horizon:project:cg_snapshots:detail"
      
      the removal of the volumes section of the link was correct for that
      change, but changing "cg_snapshot_detail" to "detail" broke the
      details link
      
      Change-Id: I7ad8673bad353a234596df16c8e64eec93733934
      Closes-Bug: #1813990
      (cherry picked from commit 468184bd)
      ca1e8f77
  4. Sep 28, 2018
    • Edward Hope-Morley's avatar
      Add enabled check in Backups panel · 02e405dc
      Edward Hope-Morley authored
      If enable_backup is False in OPENSTACK_CINDER_FEATURES
      then we should not display the backups panel.
      
      Change-Id: I276eebf0f11406bf354f5d8bbecef7b244d6d340
      Closes-Bug: #1778771
      (cherry picked from commit 6c2225ba)
      02e405dc
  5. Aug 21, 2018
    • Nguyen Hai's avatar
      import zuul job settings from project-config · f37e5302
      Nguyen Hai authored
      This is a mechanically generated patch to complete step 1 of moving
      the zuul job settings out of project-config and into each project
      repository.
      
      Because there will be a separate patch on each branch, the branch
      specifiers for branch-specific jobs have been removed.
      
      Because this patch is generated by a script, there may be some
      cosmetic changes to the layout of the YAML file(s) as the contents are
      normalized.
      
      See the python3-first goal document for details:
      https://governance.openstack.org/tc/goals/stein/python3-first.html
      
      Change-Id: I85b8f668d6e90806ac76882723b20fd829a79d70
      Story: #2002586
      Task: #24299
      f37e5302
  6. Jun 04, 2018
    • Timur Sufiev's avatar
      Make @memoize thread-aware · 0de6c6a0
      Timur Sufiev authored
      
      If 2 parallel threads simultaneously make an expensive call to a
      memoized function with arguments for which the returned value wasn's
      cached before, 2 calls are effectively made in parallel.
      
      It's better to avoid such a situation and if one thread already
      initiated an expensive call, block on it in another thread and once
      the call in the first thread is completed, unblock and reuse the value
      which is cached now.
      
      Co-Authored-By: default avatarVladislav Kuzmin <vkuzmin@mirantis.com>
      Change-Id: Id216e7b9c1bd836ee70a36ecb378e7d51d3821d2
      (cherry picked from commit a72a1eca)
      0de6c6a0
  7. Apr 30, 2018
  8. Apr 11, 2018
    • Akihiro Motoki's avatar
      Fix pep8 errors · 8458e258
      Akihiro Motoki authored
      Recent pep8 upgrade and corresponding pycodestyle update break
      horizon pep8 job due to the new rules.
      
      This commit fixes the following new errors:
      - E226 missing whitespace around arithmetic operator
      - E241 multiple spaces after ','
      - E731 do not assign a lambda expression, use a def
      
      The following errors are added to the ignore list
      as there are many errors:
      - E402 module level import not at top of file
      - W503 line break before binary operator
      
      Conflicts:
              openstack_dashboard/dashboards/admin/aggregates/tests.py
              openstack_dashboard/dashboards/admin/instances/tests.py
              openstack_dashboard/dashboards/admin/routers/tests.py
              openstack_dashboard/dashboards/project/images/tests.py
              openstack_dashboard/dashboards/project/networks/tests.py
              openstack_dashboard/dashboards/project/routers/tests.py
              openstack_dashboard/test/test_data/neutron_data.py
              tox.ini
      
      The conflicts are due to mox-removal efforts.
      
      Change-Id: I3478b0684175d2604bbcc1d89cbfca298b97f1e1
      (cherry picked from commit f545272f)
      8458e258
  9. Mar 29, 2018
    • Zuul's avatar
      5c15fb85
    • Shu Muto's avatar
      Fix Angular errors in openstack_auth · 6f6f46dc
      Shu Muto authored
      Angular errors on login page are caused by loading ngdetails view.
      Although registration of URL for ngdetails is executed on top level
      of Horizon, ngdetails view is not needed to be loaded in login page,
      i.e. openstack_auth side.
      To fix this issue, this patch moves registration of URL for ngdetails
      into openstack_dashboard side.
      
      Conflicts:
      	openstack_dashboard/test/urls.py
      	openstack_dashboard/urls.py
      
      The above conflicts are caused by bp/django2-support which landed in Rocky,
      particully by https://review.openstack.org/#/c/527323/12.
      
      Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c
      Closes-Bug: #1754133
      Closes-Bug: #1753557
      (cherry picked from commit f494c6f2)
      6f6f46dc
  10. Mar 01, 2018
  11. Feb 16, 2018
  12. Feb 15, 2018
  13. Feb 14, 2018
  14. Feb 11, 2018
  15. Feb 09, 2018
    • David Gutman's avatar
      Views accessible via url even if user doesn't match policy rules · 1870b536
      David Gutman authored
      When a user doesn't match the policy rules of a panel then the panel tab
      is removed from the menu of the left, but panel views are still
      accessible using directly the url (ex /admin/flavors/).
      
      In most of the case, views won't work correctly because of the lack of
      right in the backend, but it may cause trouble when you play with
      policies.
      
      I think it could be more elegant to return directly a "You are not
      authorized to access this page" from the frontend when user try to
      access a view of a panel (via url) without matching the policy rules.
      
      Change-Id: I7bc93fed29568adfc14d5bcadfc8728d3b5cf633
      Closes-Bug: #1741051
      (cherry picked from commit 3f585d3b)
      1870b536
    • David Gutman's avatar
      Tabs in launch server wizard not depending on OPENSTACK_NOVA_EXTENSIONS_BLACKLIST · af6740ce
      David Gutman authored
      OPENSTACK_NOVA_EXTENSIONS_BLACKLIST is used to disable specific extension.
      In the launch instance wizard, by example the Server Group tab should be hidden
      when the extension "ServerGroups" is blacklisted but it isn't.
      
      It could be interesting to make these tabs dependent of the supported extensions.
      
      Change-Id: I15ea0f1010e3889c217c63e98f1752a4c1ad9ceb
      Closes-Bug: #1745367
      (cherry picked from commit c7bc9242)
      af6740ce
  16. Feb 08, 2018
  17. Feb 07, 2018
    • Akihiro Motoki's avatar
      Clean up broken links due to doc-migration · 0932ff57
      Akihiro Motoki authored
      view-cloud-resources.rst is dropped as the metering panel was dropped
      several releases ago.
      
      Closes-Bug: 1714753
      
      Change-Id: I483cb3dbaab23722abd2f321e8666d8beea2f7c7
      (cherry picked from commit a4d05ce5)
      0932ff57
    • Shu Muto's avatar
      Enable to refresh ngdetails view · a0fc40b4
      Shu Muto authored
      For now, refreshing ngdetails view by browser using F5 key or reload
      button, it causes 404 error from django. To fix this issue, this patch
      adds the url for '/ngdetails' into django.
      
      To reproduce navigations, each request for views.py requires
      'dashboard' and 'panel' object. Otherwise django side returns
      500 error.
      
      However the URL for request of details page (i.e. /ngdetails/)
      can not provide informations to set the proper navigation.
      
      So this patch set them to default dashboard and default panel.
      
      This patch focuses to prevent 500 error. So the issue for
      settings of proper navigation will be fixed by subsequent patch.
      
      Change-Id: Ib9f1fe48b3cdecff5ad56e68a5ba58a41cb35f38
      Closes-Bug: #1681627
      (cherry picked from commit 077163a0)
      a0fc40b4
  18. Feb 06, 2018
  19. Feb 05, 2018
  20. Feb 01, 2018
  21. Jan 31, 2018
  22. Jan 27, 2018
    • James E. Blair's avatar
      Zuul: Remove project name · e9e8b8cc
      James E. Blair authored
      Zuul no longer requires the project-name for in-repo configuration.
      Omitting it makes forking or renaming projects easier.
      
      Change-Id: I3591f07fe5321389399729f3f77cef72d00cdbfc
      e9e8b8cc
Loading