Change-Id: Ib0a99f80e6a133950498accc6153b68598f7ad20

Also clean up pre-existing pep8 violations in the
files/* dir which was previously not covered by lint testing.

Also clean-up mocking issues around apt-pkg replacements in the
unit tests.

Also fix py35 issue with enabled_manager_modules() function in the
charmhelpers library (see
https://github.com/juju/charm-helpers/pull/387).

Also fix the functional tests bundles so they actually test the
version of OpenStack that the bundle indicates.

Change-Id: I2c8d84fadc11311c622dd308c4694496872dc157

The bundle disco-stein was in the dev bundles because
a bug with the Python 3.7 syntax prevented the success of
the deployment of HA clusters. This bug is fixed, we can
reintegrate disco-stein in the gate bundles.

Other small additions:
- Passing OS env vars instead of AMULET
- removing sitepackages in tox.ini to avoid test env pollution
- skip_missing_interpreters in tox.ini set to False to avoid false
positives by skipping missing interpreters.
- adding bionic-stein bundle to gate_bundles instead of dev

LP Related-Bug: #1823718
Change-Id: Ia7093a5654a763670be05635f7f6fce292eb9c96

This is a mechanically generated patch to ensure unit testing is in place
for all of the Tested Runtimes for Train.

See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html

Note that python35-charm-jobs is retained since this charm is supported
on Xenial.

Change-Id: Ib39664a09e76cb5a3f764057b42d5cd33c1f8f75
Story: #2005924
Task: #34228

Change-Id: If9e79b22a919997961a23929435450af0883b882
Closes-Bug: #1828424
func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/5

* Move charmhelpers to the root of the charm
* sync charmhelpers to latest version

Change-Id: Id0b838f0206635cf912d205f2fb6fda7b31d0dfe

A system upgrade broke ostestr. We can fix it by just calling stestr
directly.

Change-Id: I238730d47f05ec18cc1efd7ab20b88a8c29a2858

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I376bcfa0b37407876609f1183ecb72b614160457
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Python 3.6 is installed by default in Ubuntu 18.04 LTS.
Therefore, according to Transition Plan [1],
it'll be handy to have py36 testenv.

For more details, please check Python2 Deprecation Timeline [2]
and Python3-first Goal - Completion Criteria [3].

[1] https://wiki.ubuntu.com/Python/Python36Transition
[2] https://governance.openstack.org/tc/resolutions/20180529-python2-deprecation-timeline.html
[3] https://review.openstack.org/#/c/575933/8/goals/stein/python3-first.rst@42

Change-Id: I08dc76d61c6d762c75ca6594f0a33f0042da12f3

Change bionic test from dev to gate for 18.05.

Change-Id: Ice91cd32a8e1b82be80b29e67bdeec32cfa89254

As of pip 10.0, --allow-unverified is not permitted.

Use of the flag in this repo was previously used to force
installation of python-apt to accommodate certain unit tests.

The unverified package, python-apt, is no longer necessary
for test execution.

Related-Bug: #1760720

Change-Id: Idfe5ad692a8657eaad7bb9ddc5a6ac33210cd38c

Enable Queens, and set Queens as the smoke gate

Remove soon-to-be deprecated combos

Change-Id: I905aabc8d2168e87b6d341bac45a38991f26cc57

Change-Id: I21920e173b2421b3dd077655b9b01812064b7d68

Change-Id: I4b500716f08d2041044a204951750887e34fb87a

- Turn on Zesty-Ocata Amulet test definitions.
- Standardize test-requirements.txt
- Sync charm helpers for various fixes

Change-Id: I1f161137ef00fe835bce8944285341713c2eadfa

- sync charmhelpers with fix-alpha helpers
- fix up code where the alpha comparisons are done

Change-Id: I10e3e689aba490118b84b6b9e58df1ba5632d07d
Related-Bug: #1659575

All OpenStack Charms now contain identical tox.ini files,
not to be modified or made unique within each charm repo.

This is to ensure consistency across charm repos in tox
target naming, approach and purpose, also giving the
charm dev and test experience additional consistency.

Also create empty dirs with .keep files where necessary.
Some classic charms have actions and/or lib dirs, and some
do not. In all classic charms, flake will now check those
dirs to ensure lint coverage of existing or future content.

Manually fix up test names, Makefile and other legacy
artifacts remaining from basic ceph-proxy on an old copy
of ceph-mon.

Change-Id: I54eb35d0e449f203237bdc9f065551a1fbc887a0

Avoid use of 'service --status-all' which is currently
broken on trusty for upstart managed daemons; the change
moves to detecting how the daemon is managed, and then
using upstart status XXX or the return code of service XXX
status to determine whether a process is running.

Fixes for IPv6 network address detection under Ubuntu
16.04 which changes the output format of the ip commands
slightly.

Update the version map to include 8.1.x as a Neutron
version for Mitaka.

Fixup mocking of apt during load of unit tests and ensure
that tox does not use any site packages, ensuring that
test execution is isolated from installed OS

Change-Id: I0f8d7cb2689f5e4c94390b324850e4e9b6e10eb5
Closes-Bug: 1581171
Closes-Bug: 1581598
Closes-Bug: 1580674

The new release of charm-tools no longer ships the charm
command; update minimum version requirement and switch
to using charm-proof instead, unblocking current pep8
failures across all charms.

Also pin the version of requests to 2.6.0 until theblues
(indirect dependency of charm-tools) sort out its
requirements versioning.

Change-Id: I29210e210b90aa81bf6ee9a020bd6de656750a77

This change will add two new actions to the ceph-mon charm. These
actions will allow the user to create and remove cache tiers from
existing pools.  Both writeback and read only mode are supported.

Limitations of this patch include not having fine grain control
over the cache tier properties.  Things like hit_set_count,
bloom filter control or cache sizing are not supported yet.

Change-Id: I5a37e79d0d23d35295a8ae97177c940af66b0485

Rename lint->pep8, ensure that sitepackages are used with
newer versions of tox/virtualenv.

Change-Id: Ia6b6e27692e581439e6e5a74ecaeb6b3a1e0742f