From 97e2185517b961ba8372f5763570534a6cd3cc88 Mon Sep 17 00:00:00 2001 From: David Ames <david.ames@canonical.com> Date: Thu, 10 May 2018 13:43:46 -0700 Subject: [PATCH] Re sync charm-helpers There was a mid-air collision with charm helpers syncs. The critical piece is the removal of a second stats socket line from the haproxy templates which breaks on trusty. All other amulet tests that include keystone will fail on trusty until this is landed. Change-Id: Ide3b7cbda238b9a7b93f0625c21d43335bc10e81 --- charmhelpers/contrib/openstack/amulet/utils.py | 2 ++ charmhelpers/contrib/openstack/templates/haproxy.cfg | 1 - tests/charmhelpers/contrib/openstack/amulet/utils.py | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/charmhelpers/contrib/openstack/amulet/utils.py b/charmhelpers/contrib/openstack/amulet/utils.py index 84e87f5d..ef785423 100644 --- a/charmhelpers/contrib/openstack/amulet/utils.py +++ b/charmhelpers/contrib/openstack/amulet/utils.py @@ -40,6 +40,7 @@ import novaclient import pika import swiftclient +from charmhelpers.core.decorators import retry_on_exception from charmhelpers.contrib.amulet.utils import ( AmuletUtils ) @@ -423,6 +424,7 @@ class OpenStackAmuletUtils(AmuletUtils): self.log.debug('Checking if tenant exists ({})...'.format(tenant)) return tenant in [t.name for t in keystone.tenants.list()] + @retry_on_exception(num_retries=5, base_delay=1) def keystone_wait_for_propagation(self, sentry_relation_pairs, api_version): """Iterate over list of sentry and relation tuples and verify that diff --git a/charmhelpers/contrib/openstack/templates/haproxy.cfg b/charmhelpers/contrib/openstack/templates/haproxy.cfg index f99d99f1..d36af2aa 100644 --- a/charmhelpers/contrib/openstack/templates/haproxy.cfg +++ b/charmhelpers/contrib/openstack/templates/haproxy.cfg @@ -6,7 +6,6 @@ global group haproxy spread-checks 0 stats socket /var/run/haproxy/admin.sock mode 600 level admin - stats socket /var/run/haproxy/operator.sock mode 600 level operator stats timeout 2m defaults diff --git a/tests/charmhelpers/contrib/openstack/amulet/utils.py b/tests/charmhelpers/contrib/openstack/amulet/utils.py index 84e87f5d..ef785423 100644 --- a/tests/charmhelpers/contrib/openstack/amulet/utils.py +++ b/tests/charmhelpers/contrib/openstack/amulet/utils.py @@ -40,6 +40,7 @@ import novaclient import pika import swiftclient +from charmhelpers.core.decorators import retry_on_exception from charmhelpers.contrib.amulet.utils import ( AmuletUtils ) @@ -423,6 +424,7 @@ class OpenStackAmuletUtils(AmuletUtils): self.log.debug('Checking if tenant exists ({})...'.format(tenant)) return tenant in [t.name for t in keystone.tenants.list()] + @retry_on_exception(num_retries=5, base_delay=1) def keystone_wait_for_propagation(self, sentry_relation_pairs, api_version): """Iterate over list of sentry and relation tuples and verify that -- GitLab