Skip to content
Snippets Groups Projects
  1. Apr 01, 2019
    • Eric Desrochers's avatar
      Not implicitly set vol_device_name to vda · 0df60f4d
      Eric Desrochers authored
      Using a scsi decorated image with:
      hw_disk_bus='scsi'
      hw_scsi_model='virtio-scsi'
      
      This solve the case where an instance is
      launched with 'image' selected as boot
      source with a new volume. This will result
      in /dev/vda instead of /dev/sda as it
      should.
      
      Not specifying device name in
      setFinalSpecBootImageToVolume() leaves the
      decision to nova to determine it.
      
      Example:
      -------
      VM boot volume without scsi meta data decoration:
      Attached To
      0a0cd660-7ce3-4033-9983-2e1099edc5f0 on /dev/vda
      
      VM boot volume with scsi meta data decoration:
      Attached To
      91f50dbc-8bdf-4293-84ea-fc5df27b5ee4 on /dev/sda
      --------
      
      Note: This commit doesn't address cases for
      where instances are launched using existing
      volume and snapshot, this will involve more
      work to migrate the code from BDMv1 to BDMv2.
      
      Closes-Bug #1560965
      
      Change-Id: I9d114c2c2e6736a8f1a8092afa568f930b656f09
      (cherry picked from commit 79a4c3bd)
      0df60f4d
  2. Mar 29, 2019
  3. Mar 22, 2019
    • Akihiro Motoki's avatar
      network topology: handle port AZ correctly · 94bf6166
      Akihiro Motoki authored
      Previously d3 version of the network topology view handles ports with
      device_owner 'compute:nova' and 'compute:None' specially. This leads
      to the situtaion that neutron ports with non-default AZ are not shown
      properly. There is no reason to handle neutron ports with the default
      AZ differently. What we would like to do is just to classify neutron
      ports attached to nova servers.
      
      This commit changes the logic to check device_owner of ports have
      a prefix 'compute:'. Note that we also need to check if device_owner
      is a string before checking the prefix.
      
      Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
      Closes-Bug: #1820260
      (cherry picked from commit ffbe0e2f)
      94bf6166
  4. Mar 11, 2019
  5. Mar 07, 2019
  6. Mar 06, 2019
    • Akihiro Motoki's avatar
      Use correct cinder API version for tenant_absolute_limits · c37a0f26
      Akihiro Motoki authored
      To verify resource usages when updating project quotas,
      project_id query parameter needs to be supported in
      tenant_absolute_limits in the cinder API.
      
      This is supported in 3.39 or later in the cinder API.
      API vesions shipped with released versions (pike, queens and
      rocky) are selected as verified versions.
      
      Change-Id: If5fc190988cf173387da2b66be23db9134310692
      Closes-Bug: #1810309
      (cherry picked from commit If5fc190988cf173387da2b66be23db9134310692)
      c37a0f26
  7. Mar 01, 2019
  8. Feb 03, 2019
    • jmoffitt's avatar
      Consistency Group Snapshots detail url is wrong · f3a66ae3
      jmoffitt authored
      The link in the consistency group table for "detail" is a mismatch
      for the corresponding value in the urls.py file, causing cg snapshots
      clicks to not load details for the user.
      
      This bug was introduced in https://review.openstack.org/#/c/429506
      where the link in tables.py was changed from:
      "horizon:project:volumes:cg_snapshots:cg_snapshot_detail"
      to
      "horizon:project:cg_snapshots:detail"
      
      the removal of the volumes section of the link was correct for that
      change, but changing "cg_snapshot_detail" to "detail" broke the
      details link
      
      Change-Id: I7ad8673bad353a234596df16c8e64eec93733934
      Closes-Bug: #1813990
      (cherry picked from commit 468184bd)
      f3a66ae3
  9. Jan 08, 2019
    • Ivan Kolodyazhny's avatar
      Add Fix django.contrib.auth.middleware monkey patching for APITestCase · 9ba7a036
      Ivan Kolodyazhny authored
      This patch rollbacks changes in APITestCase introduced in the
      0d163613 commit to unblock Horizon
      plugins gates.
      
      Conflicts:
              openstack_dashboard/test/helpers.py
      
      Note(elod.illes): the above mentioned change in APITestCase was
      backported to queens, so this rollback should be backported, too.
      
      Change-Id: I6b2be31568e4aa4273990f9cfa76ca139620c84b
      Closes-bug: #1806053
      Closes-bug: #1805240
      (cherry picked from commit de69edd0)
      (cherry picked from commit 85fef71c)
      9ba7a036
  10. Jan 05, 2019
  11. Jan 02, 2019
  12. Dec 21, 2018
    • Yves-Gwenael Bourhis's avatar
      Fix images minimum ram and disk default values · 5b6ee8fd
      Yves-Gwenael Bourhis authored
      When uploading an image, if we do not set a minimum ram and disk size we
      try to send "None" to glance.
      We should instead send "0" and glance will calculate the size from the
      provided image.
      
      Change-Id: Ia1aeabcdcf021943ebb7a4e35939c383ac820b19
      Closes-Bug: #1809121
      (cherry picked from commit 65b21e7f)
      5b6ee8fd
  13. Nov 23, 2018
  14. Nov 20, 2018
    • Mathieu Gagné's avatar
      Fix django.contrib.auth.middleware monkey patching · 6ae1f5e2
      Mathieu Gagné authored
      The "request" attribute is not available in
      openstack_auth.backend.KeystoneBackend.get_user when session data is restored
      and it's the first request to happen after a server restart.
      
      As stated by the function document, the "request" attribute needs to be
      monkey-patched by openstack_auth.utils.patch_middleware_get_user
      for this function to work properly.
      
      This should happen in openstack_auth.urls at import time. But there is nowhere
      in Horizon where this module is imported at startup. It's only introspected
      by openstack_dashboard.urls due to AUTHENTICATION_URLS setting.
      
      Without this monkey-patching, the whole authentication mechanism falls back
      to "AnonymousUser" and you will get redirected to the login page due
      to horizon.exceptions.NotAuthenticated being raised by
      horizon.decorators.require_auth as request.user.is_authenticated will be False.
      
      But if a user requests a page under auth/, it will have the side-effect of
      monkey-patching django.contrib.auth.middleware as expected. This means that
      once this request is completed, all following requests to pages other than
      the ones under auth/ will have there sessions properly restored and
      you will be properly authenticated.
      
      Therefore this change introduces a dummy middleware which sole purpose is
      to perform this monkey-patching as early as possible.
      
      There is also some cleanup to get rid of the previous attempts at
      monkeypatching.
      
      Closes-bug: #1764622
      
      [backport specific notice]
      Queens horizon supports Django 1.8 and 1.11.
      The key point is Django 2.0 is not supported.
      Django 2.0 dropped the legacy Django middleware interface and
      the new interface is not supported in Django 1.8.
      Thus, this backport changes OpenstackAuthMonkeyPatchMiddleware in
      openstack_auth/middlware.py to use the legacy middleware interface.
      
      Conflicts:
      	openstack_dashboard/settings.py
      	openstack_dashboard/test/helpers.py
      
      Change-Id: Ib9912090a87b716e7f5710f6f360b0df168ec2e3
      (cherry picked from commit 0d163613)
      (cherry picked from commit 8851866a)
      6ae1f5e2
    • OpenStack Proposal Bot's avatar
      Imported Translations from Zanata · 52a011c0
      OpenStack Proposal Bot authored
      For more information about this automatic import see:
      https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
      
      Change-Id: I0f2e0df82a81ec9e8fc345c1c33fdc815498790e
      52a011c0
  15. Nov 08, 2018
  16. Oct 21, 2018
  17. Sep 28, 2018
    • Edward Hope-Morley's avatar
      Add enabled check in Backups panel · 5d1690da
      Edward Hope-Morley authored
      If enable_backup is False in OPENSTACK_CINDER_FEATURES
      then we should not display the backups panel.
      
      Change-Id: I276eebf0f11406bf354f5d8bbecef7b244d6d340
      Closes-Bug: #1778771
      (cherry picked from commit 6c2225ba)
      5d1690da
  18. Sep 13, 2018
  19. Sep 07, 2018
  20. Aug 28, 2018
  21. Aug 21, 2018
    • Nguyen Hai's avatar
      import zuul job settings from project-config · 7ade1800
      Nguyen Hai authored
      This is a mechanically generated patch to complete step 1 of moving
      the zuul job settings out of project-config and into each project
      repository.
      
      Because there will be a separate patch on each branch, the branch
      specifiers for branch-specific jobs have been removed.
      
      Because this patch is generated by a script, there may be some
      cosmetic changes to the layout of the YAML file(s) as the contents are
      normalized.
      
      See the python3-first goal document for details:
      https://governance.openstack.org/tc/goals/stein/python3-first.html
      
      Change-Id: I5d2ade7b7b4a3ce2250e893b941ad81746c00299
      Story: #2002586
      Task: #24299
      7ade1800
  22. Aug 09, 2018
  23. Jun 20, 2018
  24. Jun 18, 2018
  25. Jun 05, 2018
  26. Jun 01, 2018
    • Feilong Wang's avatar
      Sort image list by name when launch instance · 7fe81e40
      Feilong Wang authored
      Just like the flavor sort issue, this is another regression issue
      when we shift from the legacy launch instance wizard. By default,
      the image list should be ordered by name.
      
      Change-Id: Id619ad531f7e91326694ee90c112d6a7db0d14ad
      (cherry picked from commit 71c48804)
      7fe81e40
  27. May 30, 2018
    • Akihiro Motoki's avatar
      Update RHEL/CentOS horizon install instruction · b7d890bb
      Akihiro Motoki authored
      openstack-dashboard.conf in openstack-dashboard package
      for RHEL/CentOS does not contain WSGIApplicationGroup configuration
      which is required to make the dashboard work correctly.
      
      Change-Id: Ic62fa29015ec153eada9d5e1ba5c06dab3a5eeca
      Closes-Bug: #1741354
      (cherry picked from commit a180bafb)
      b7d890bb
  28. May 23, 2018
  29. May 15, 2018
  30. May 14, 2018
    • Guillaume Le Blanc's avatar
      Allow OVA upload for images · e41a54d4
      Guillaume Le Blanc authored
      Bug #1641383 was not fixed for REST API call.
      The two implementation of create_image_metadata are merged
      into api/glance.py.
      
      There were minor differences in field naming and handling
      (min_ vs minimum_, is_public vs public vs visibility).
      This commit normalizes them to simplify the logic.
      
      Closes-Bug: #1757136
      Change-Id: I41e9d94345151bc4473d704cdc040ed77870ce45
      (cherry picked from commit e3626260)
      e41a54d4
    • Akihiro Motoki's avatar
      Improve mocking in REST API tests (test_glance) · 3982960f
      Akihiro Motoki authored
      The current REST API tests have a lot of rooms to be improved like:
      - mocking the whole module of the API wrapper
      
      ---
      [Note on a backport to queens]
      
      This is a preparation of a backport proposed in [1].
      mock usage of api.rest.test_glance was improved in Rocky and
      the test backported in [1] assumes the improved version of the test.
      This is a test improvement which does not touch the main code,
      so it is a safe backport.
      
      The signature of create_mocks was changed in [2], so the arguments
      of create_mocks in this backport are adjusted to Queens version.
      
      [1] https://review.openstack.org/#/c/566267/
      [2] https://review.openstack.org/#/c/545472/
      
      Change-Id: Id573d97c467fe8457f60baff089d60c18345395e
      Partial-Bug: #1752917
      (cherry picked from commit dfa68461)
      3982960f
  31. May 08, 2018
  32. Apr 30, 2018
  33. Apr 26, 2018
  34. Apr 25, 2018
Loading