pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

Change-Id: If407d8790ea22ce50a1ac33d26f6ec32f1ac3535

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

According to the code in [1], if there is a host in the aggregate,
an error will be shown when deleting.
[1]https://github.com/openstack/nova/blob/948d63c6dc190ef94041fbeaa30091358a33c484/nova/compute/api.py#L5420-L5423

This Patch hide the delete button if a host in the aggregate

Change-Id: I79c1e32b84fef00a242e1adf5d87531d3f407c34
Closes-Bug: #1829102

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

The function of exceptions.handle can throw an error message,
no need messages.error

Change-Id: I9cd07a314a13ec3118d031d29d88b0d926389c52

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

The update.html is not used, I think we can delete it

Change-Id: I63cea8f889f98aef93bf43bd74bec7df2a020480

Ivan Kolodyazhny authored 6 years ago and Claudio Pisa committed 6 years ago

Change-Id: I16b62d21287865aeeb6238bae369b616e89aa10e

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

When the modal box is opened,
horizon.datatables.qs will be empty.
When update row, the cache cannot be updated in real time，
this makes filtering problems.

Change-Id: I605726fa78c20126a7f48ad3b2953bc6b416349f
Closes-Bug: #1817656

BubaVV authored 6 years ago and Claudio Pisa committed 6 years ago

By default, Horizon doesn't compile localized messages in tox
environment. It leads to silent fail of language change with 'Success'
message. Proposed patch includes compilation of messages to tox runserver
command

Change-Id: I149a622a81a17e9d951c68829349fc70fbb8ed2a

Akihiro Motoki authored 6 years ago and Claudio Pisa committed 6 years ago

A fix for bug 1824017 bumped the minimum version requirement of
python-cinderclient to 4.0.0. The fix was backported to stable/stein,
so the minimum version bump should be covered by a release note.

python-cinderclient requirement is bumped to >=4.0.1
as 4.0.0 is blocked by global-requirements.txt [1].

It was suggested by the release team in the review of
horizon stein update release [2].

[1] https://opendev.org/openstack/requirements/src/commit/1baf07a77333fc57d9d4a669d0265b0e687fd031/global-requirements.txt#L256
[2] https://review.opendev.org/#/c/655447/

Change-Id: I2b43e159da7e58980b2810a104ae2418f237d1c7
Related-Bug: #1824017

Frank Kloeker authored 6 years ago and Claudio Pisa committed 6 years ago

service command is a wrapper for SystemV init scripts.
It's still working, but usage of systemd (systemctl) is more common since Ubuntu 16.04.

Change-Id: I59db9bf29696a1e64cdde322df29ec1a827d7e84

Ivan Kolodyazhny authored 6 years ago and Claudio Pisa committed 6 years ago

SHOW_KEYSTONE_V2_RC is deprecated since Stein release and it's safe
to remove it now.

Keystone v2 support removal will be implemented in a follow up patch.

Change-Id: Ib3098789a3aef47f4f4b84fd56f03376ce2ea96f

manchandavishal authored 6 years ago and Claudio Pisa committed 6 years ago

There's a regression[0] in bandit 1.6.0 which causes bandit to stop
respecting excluded directories, and our tests throw a bunch of
violations. Blacklist this version, but allow newer versions as there is
already a pull request[1] to fix it, and I expect it will be included in
the next release.

[0] https://github.com/PyCQA/bandit/issues/488
[1] https://github.com/PyCQA/bandit/pull/489
For additional details, refer to ML Thread[1]

[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006116.html

Change-Id: I01b3ee75aa52b2711bacbf26690ce55a4c3f336e

manchandavishal authored 6 years ago and Claudio Pisa committed 6 years ago

Sphinx 2.0 no longer works on python 2.7, so we need to start capping
it there as well.

Change-Id: I15172984b548bc2ad9ed6ab015da525ba6a49dd5

Akihiro Motoki authored 6 years ago and Claudio Pisa committed 6 years ago

This is a follow-up patch of https://review.opendev.org/#/c/656456/
During the review, it turns out that the logic is too deep and
we cannot add more "if" clause. This commit tries to address it.

Change-Id: If133b1bed8ae1a591c4ce34e0a86d6dc1c138c68

manchandavishal authored 6 years ago and Claudio Pisa committed 6 years ago

These variables are not used anymore.
This patch removes them.

Change-Id: Id8035412a4f30b1b297acd71cda1d4eff61f5399

OpenStack Proposal Bot authored 6 years ago and Claudio Pisa committed 6 years ago

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ib1edeafd48098284cb54e45a417421cb29c7bca6

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

When an element is required and hidden,
the browser will report an error when submitting the form.

Here is the code location where Django adds the required attribute to the element:
https://github.com/django/django/blob/master/django/forms/boundfield.py#L221-L222

Change-Id: I68e1145efbe1837861aa1d66fceec497d6d97cb9
Closes-Bug: #1811181

OpenStack Proposal Bot authored 6 years ago and Claudio Pisa committed 6 years ago

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I77885e2730ad5da9ad20624c0f070619f56075ee

OpenStack Proposal Bot authored 6 years ago and Claudio Pisa committed 6 years ago

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I887cb149d10d333eb06b3f821ec6223bc8c48d11

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

The name is not required, so data["name"] may be empty.
When data["name"] is empty, get the id value.
This patch correct error messages on update network form

Change-Id: Icc1b0ad7077dedfea77d6c0225dc2747d7efc1b5

ZhongShengping authored 6 years ago and Claudio Pisa committed 6 years ago

This goal is to implement the process set out in the 2018-10-24 Python
Update Process TC resolution[1], for the Train cycle to ensure unit
testing is in place for all of the Tested Runtimes for Train[2].
Using the Zuul template for Train will ensure that all projects that
support Python3 will be tested against the agreed runtime versions,
and make it easier to update them in future.

[1]https://governance.openstack.org/tc/resolutions/20181024-python-update-process.html
[2]https://governance.openstack.org/tc/reference/runtimes/train.html

Change-Id: I406a4f1ecbff5b6c8e18ff1b93a3b2ceef49343a

OpenStack Proposal Bot authored 6 years ago and Claudio Pisa committed 6 years ago

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I6e7a0ac244a6843ce889009779eaa4b44764ff22

Akihiro Motoki authored 6 years ago and Claudio Pisa committed 6 years ago

When creating a server using an existing volume or volume snapshot,
horizon specified a device_name 'vda'.
However the device name depends on bus type or something and
this causes incorrect volume information in the instance detail page
(and nova volume-attachments CLI output).
For detail background, see bug 1560965.

block_device_mapping v1 required device_name but it is no longer
required to specify device_name 'vda' in block_device_mapping v2
in Nova create-server API.

This commit changes to use block_device_mapping v2 so that
we can avoid specifying device_name.

Change-Id: Ice1a6bb2dcddab0a89c99f345d1f2cd101955b28
Partial-Bug: #1560965

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

The number of rbac policy reaches the maximum quota,
when create rbac policy,
an error message is shown and the error information is unclear.
This patch correct the error message

Change-Id: I2d8207ed1f87c2f604d4f3d2bf34f8214e785203
Closes-Bug: #1826693

Akihiro Motoki authored 6 years ago and Claudio Pisa committed 6 years ago

Cinder consistency group has been replaced by the generic group feature.
Horizon support of the generic group (in the project dashboard) is
available since Rocky release and it covers all existing support
for consistency group in horizon.

The consistency group support is horizon was marked as deprecated
in Stein release [1].

This commit drops the consistency group support.

[1] https://review.openstack.org/#/c/626846/

Change-Id: I11187d2b03b7e0033a6c6ba3f8be25b8b5e4dd74

OpenStack Proposal Bot authored 6 years ago and Claudio Pisa committed 6 years ago

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I7d380b6e12099f3a7c4380903e9259233a833612

Ivan Kolodyazhny authored 6 years ago and Claudio Pisa committed 6 years ago

ENABLE_FLAVOR_EDIT is deprecated since Pike release and is not used
anywhere.

Change-Id: I06d5252c8f7bd955025587393f5d8ff00fe01c3b

Dmitriy Rabotjagov authored 6 years ago and Claudio Pisa committed 6 years ago

KeyError was raised when volume was created from image and
then this image is deleted. THis patch adds additional check
to avoid such situations.

Change-Id: I85712fd9587d8815d2f3c74227ded9a4f62296f3

Adrian Turjak authored 6 years ago and Claudio Pisa committed 6 years ago

The default content-type is html, and under certain
circumstances like devstack the html has some additional
comments added. Because this specific content is meant
to be parsed as json those extra html comments break the
modal.js code.

We can't set the content-type to json without rewriting parts of
modal.js, as it will will parse it into an object early and then
modal.js will fail as it attempts to parse an object into json.

Change-Id: If5a9ee7fe4273dc368dec7767a55d4467bf6a1a7
Closes-bug: #1824484

Riedo Ilofin authored 6 years ago and Claudio Pisa committed 6 years ago

This is bug from initial commit Ida2e836cf81d2b96e0b66afed29a900c312223a4

Check box 'unrestricted' is Bool type and if left unticked it was set to
'None' which is not Bool type.

This fixes the bug and removes 'or None' which sets the 'unrestricted' to
'False'

Change-Id: I7b3b4b82624e61edfea5d0b42d9179ec2216277f
Closes-Bug: #1821115

pengyuesheng authored 6 years ago and Claudio Pisa committed 6 years ago

When there is more than one Extra Specs in Volume Type Extra Specs,
then create an Extra spec with an invalid key name like "#^&*",
the form prompts a wrong error message.
This patch corrects the error message.

Change-Id: I5ecdbb37953e95b302a254748cfc2a6a615c7d4b
Closes-Bug: #1822924

OpenStack Proposal Bot authored 6 years ago and Claudio Pisa committed 6 years ago

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I63eb0cc9e086318169bf458275017845382d468b

ZhongShengping authored 6 years ago and Claudio Pisa committed 6 years ago

Thorough replacement of git.openstack.org URLs with their opendev.org
counterparts.

Change-Id: I7f5506455ed52e4670b8e428548e931db13b13db

BubaVV authored 6 years ago and Claudio Pisa committed 6 years ago

Several Angular based dashboards, such as images and snapshots,
not regenerated after some item on this page changes its status
from transition state.
For example, an image may be shown forever in the "Creating" state
with running progress bar. To improve UI this patch re-upload items
list until some item in transition state.
If status of item changed, then 'trackBy' field changed and
Angular will re-render row with this particular item with
ng-repeat-start directive and won't re-render all entire page.

Change-Id: I2308baebb65b11180d66bd69d834386022c2ad84
Closes-bug: #1797592