There's a regression[0] in bandit 1.6.0 which causes bandit to stop
respecting excluded directories, and our tests throw a bunch of
violations. Blacklist this version, but allow newer versions as there is
already a pull request[1] to fix it, and I expect it will be included in
the next release.

[0] https://github.com/PyCQA/bandit/issues/488
[1] https://github.com/PyCQA/bandit/pull/489
For additional details, refer to ML Thread[1]

[1] http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006116.html

Change-Id: I01b3ee75aa52b2711bacbf26690ce55a4c3f336e

Horizon uses python-memcached while running "tox -e runserver"
so we need to add it to test-requirement.txt as well as
lower-constraints.txt.

Change-Id: I4319cf1a54310171baf1dbaf2e10acae8123dac6

tests.py files are excluded from targets checked by pylint
because it takes longer and longer time to check them somehow.

pylint 2.2.x is supported only in Python 3 and we already switched
our pep8 basepython to python3, so pylint and astroid are installed
only for python3. This seems the easiest way to ensure py27 env works.

literal-comparison error in openstack_dashboard/api/nova.py
is also fixed in this commit as it is simple enough.

Change-Id: Ic8868a44b296dba457be721716ca6f9d37ad9369

Fix the following new errors:
* E305 expected 2 blank lines after class or function definition, found 1
* E126 continuation line over-indented for hanging indent

max_line_length is set to 80 as the default value in pycodestyle is 79
but horizon uses 80 as max_line_length.

Ignore W504 and F405 by configurations.
Reasons of disabling them are explained as comments in tox.ini.

Change-Id: Iee8bcd60c30883fc8c74f08cf20af853cbb5e271

requests is used in non-test code in horizon
(openstack_dashboard/exceptions.py).
It should be declared in requirements.txt.

Closes-Bug: #1789040
Change-Id: I325b5344d45f797d256bb213093082927068a88e

This commit adds two new tox environments for bandit scanner. To run any
of them you can use tox commands:

1) 'tox -e bandit' to run bandit scanner against all the code
2) 'tox -e bandit-baseline' to run bandit scanner only against the last
commit or the current changes.

Bandit job uses 'bandit-baseline' tox environment to veryfy that no new
issues were introduced.

Change-Id: I1fc3bb0d5d151f215b9efc916f921fabaa72e7d8

Nose has been in maintenance mode for the past several years. It has
issue with exit code [1] which leads to false positive results for our
seleniun-headless job.

This patch changes test runner for Horizon tests and does the following
things:

* Django test runner  executes test in a different order than Nose does.
  That's why we've got an issue with side-effect in
  horizon.tests.unit.tables.test_tables.MyToggleAction class. This patch
  adds workaround to it.
* Rename filename of test files to names starting with 'test_'
  so that the django test runner can find tests expectedly.
* '--with-html-output' option is temporary dropped and will be added in
  a following patch.
* Integraion tests is marked via django.test.tag mechanism which is
  introduced in Django 1.10
* 'selenium-headless' is broken now because we don't have geckodriver on
  gates, this patch makes it non-voting.
* 'tox -e cover' is fixed
* Remove @memorized decorator from
  dashboards.project.images.images.tables.filter_tenant_ids function.

[1] https://github.com/nose-devs/nose/issues/984

Depends-On: https://review.openstack.org/572095
Depends-On: https://review.openstack.org/572124
Depends-On: https://review.openstack.org/572390
Depends-On: https://review.openstack.org/572391

Related blueprint: improve-horizon-testing
Change-Id: I7fb2fd7dd40f301ea822154b9809a9a07610c507

Create a tox environment for running the unit tests against the lower
bounds of the dependencies.

Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.

Add openstack-tox-lower-constraints job to the zuul configuration.

See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.

---

horizon specific change:
* Django minimum version is bumped to >=1.11 as horizon rocky
  dropped Django 1.8-1.10 support.
* django-babel needs to be bumped to 0.6.2 to support Django 2.0
  https://github.com/python-babel/django-babel/commit/8762ff5dc00c4c552655134970c8a261f9bd7366
* nose-exclude needs to be bumped to 0.5.0 to run horizon unit tests
  properly. According to my test, 0.4.0 also works but this is
  a testing dependency, so we don't need to care multiple versions much.
  Otherwise only one test is run for openstack_dashboard unit tests.

https://review.openstack.org/555402

 allows us to bump lower requirements.

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I73c3e4531c57d015f6016ca00b056a6fd0d8fc1a
Depends-On: https://review.openstack.org/555034
Depends-On: https://review.openstack.org/555402


Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Signed-off-by: Akihiro Motoki <amotoki@gmail.com>

The detail is described in the following links:
https://governance.openstack.org/tc/reference/project-testing-interface.html
http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html

doc8 command is dropped from docs and releasenotes tox envs.
We run doc8 in pep8 tox env, so this hurts nothing.

Change-Id: I24271b527258b1de4cf26ca7efd625954eb834de

Change-Id: Icd0237df4052d108035334b66c5ae2139d639e4a

Change-Id: I65c2f5d032c68494ab9a1bdbc96775c57873f056

Change-Id: I586ac5edaed0886fecb1691338590cda83990f66

In order to deal with horizon going into the upper-constraints file so
that horizon plugins can consume it normally, we need to align the
constraints invocation in horizon's tox.ini. This means putting the -C
argument into the dependencies list rather than the pip install line so
that it doesn't get appended to tox installing horizon itself.

While we're in here, move nosehtmloutput into test-requirements so that
we don't need to do .[test] which also doesn't work with constraints.

Needed-By: https://review.openstack.org/550475
Change-Id: I736f79010c2d34e25d41d967a38128c2263ed13f

Change-Id: I28d8c180a5d45dd996d280a6a8a7c071679d111a

Change-Id: I15b865fc88f6cd4047edd04e51dab65c2ef9ca38

Change-Id: Ie7a7e6613eb154b79c322d171005b91726b172fa

Moves Django OpenStack Auth content to Horizon, since they are so
tightly coupled. This cleans up the development workflow and should
make keystone / auth related contributions easier.

Implements: blueprint merge-openstack-auth
Change-Id: Ia1cdc47bad1ca6e633073a9f9445b0c7f70d05bc

Change-Id: I57d0633ae6ca64badb04fcad622ea14c4dfffcdd

Change-Id: I18c9d75607dc4652d6c8c2ce139106effd060fc8

Change-Id: I75b6fc8284a2824a0cae30835ff409cc5b0527f9

It is not strictly needed.

Change-Id: I37b2623ec834533a7ecae63084e2c2c04ecc1751

Change-Id: I6df6d6a4c34f60cfd6e9f9248f41dc351ff851b4

Change-Id: I7a7fd6b1088556e301eb0d186326d4cb5b503e28

Change-Id: I64bb12e6549d5dd41d11b6f397a0830dca50d5bd

doc8 is a linter for documents and used in openstack-manuals.
It is better to enforce document linters for simple checking.

The current rules are really simple like:
- line length check (80 chars)
- new line at the end of file

Change-Id: I3810df521068ffc97e25a5fc56b72397bf9783bc

In reviews we usually check import grouping but it is boring.
By using flake8-import-order plugin, we can avoid this.
This flake8 plugin is already used in tempest.
It enforces loose checking so it sounds good to use.

Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.

Change-Id: I8ccd05eb70350a2441cc2a4d1eafc09ee690b83b

Change-Id: I99066250175bf71f73297936baba6a8ec531142c

Horizon uses the openstackdocstheme and doesn't need oslosphinx.

Change-Id: I2cb1f0d03d5eab7b5288801877383bbf0aed93a6
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: I5cdf968d8c444ef38c0a33b390a21b6ed798fb21

This patch is the first in a series improving Horizons documentation. It
aims to make the initial quick start section clearer, updates the
information to remove some redundant information, and updates the
appearance to match the rest of the openstack docs.

Change-Id: I942e62b6c2c272dc2b5c91bca42c77677bb4e09d
Implements: blueprint pike-docs-overhaul

Change-Id: I621d101f15941e97b2ff8eca9f023e7addcbe106

Change-Id: I7617d5c362234edb2a34feef513ecda625535732

Change-Id: I9595fd8e16cf8cb33934d54f80ae32a69381aef1

hacking version is managed in test-requirements.txt and the latest
version is 0.13.0 now.

However 0.13.0 is in very sorry shape as the Change-Id of hacking
I714caa085fa35cb4aac3b65c73a7de6d4807d04d .

So this patch updates our test-requirements.txt to avoid using
0.13.0.

Change-Id: I2fe6436d2cab2a1acbda9a93d3a9e11a41574c78

Change-Id: Ie0e48dc9be9a24d0737a398064c65777ee35f79b

Change-Id: I4d0a95b3c80d6f49894e4bdfeb8ff51d31024c3e

Change-Id: I7b598a5a001c01dadb366811542d7605a67ebd4d

Change-Id: I88e66c1c3f6b29c070106c65fda0c8ddb0a98d0c

Change-Id: I79068bfb1f2513c7f78a0b95e4e07ef1cf86fe03

Change-Id: Ie2e0aaec42fb060ceead66a0096f20e41fa2fab6