This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I30b1c6585e5e5545e93cd03d03b87bc37cea5e65

Using a scsi decorated image with:
hw_disk_bus='scsi'
hw_scsi_model='virtio-scsi'

This solve the case where an instance is
launched with 'image' selected as boot
source with a new volume. This will result
in /dev/vda instead of /dev/sda as it
should.

Not specifying device name in
setFinalSpecBootImageToVolume() leaves the
decision to nova to determine it.

Example:
-------
VM boot volume without scsi meta data decoration:
Attached To
0a0cd660-7ce3-4033-9983-2e1099edc5f0 on /dev/vda

VM boot volume with scsi meta data decoration:
Attached To
91f50dbc-8bdf-4293-84ea-fc5df27b5ee4 on /dev/sda
--------

Note: This commit doesn't address cases for
where instances are launched using existing
volume and snapshot, this will involve more
work to migrate the code from BDMv1 to BDMv2.

Closes-Bug #1560965

Change-Id: I9d114c2c2e6736a8f1a8092afa568f930b656f09
(cherry picked from commit 4788c4d2)

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ib04adcbe30b839a9d3346fcdf81bad7371ab39f8

Previously d3 version of the network topology view handles ports with
device_owner 'compute:nova' and 'compute:None' specially. This leads
to the situtaion that neutron ports with non-default AZ are not shown
properly. There is no reason to handle neutron ports with the default
AZ differently. What we would like to do is just to classify neutron
ports attached to nova servers.

This commit changes the logic to check device_owner of ports have
a prefix 'compute:'. Note that we also need to check if device_owner
is a string before checking the prefix.

Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d
Closes-Bug: #1820260
(cherry picked from commit ffbe0e2f)

That function is buggy and can't handle the Chinese language codes.

Closes-Bug: #1818639
Change-Id: I6ea03949f3ad6db82f5965de3fa028a84edf6cf3
(cherry picked from commit 6372a689)

To verify resource usages when updating project quotas,
project_id query parameter needs to be supported in
tenant_absolute_limits in the cinder API.

This is supported in 3.39 or later in the cinder API.
API vesions shipped with released versions (pike, queens and
rocky) are selected as verified versions.

Change-Id: If5fc190988cf173387da2b66be23db9134310692
Closes-Bug: #1810309
(cherry picked from commit 32bfbbf1)

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I77a6686db5539b8fd7fb75cfe073e4188c960d18

The link in the consistency group table for "detail" is a mismatch
for the corresponding value in the urls.py file, causing cg snapshots
clicks to not load details for the user.

This bug was introduced in https://review.openstack.org/#/c/429506
where the link in tables.py was changed from:
"horizon:project:volumes:cg_snapshots:cg_snapshot_detail"
to
"horizon:project:cg_snapshots:detail"

the removal of the volumes section of the link was correct for that
change, but changing "cg_snapshot_detail" to "detail" broke the
details link

Change-Id: I7ad8673bad353a234596df16c8e64eec93733934
Closes-Bug: #1813990
(cherry picked from commit 468184bd)

This patch is directly proposed to stable/rocky.

A cherry-pick of I6b2be31568e4aa4273990f9cfa76ca139620c84b
to stable/rocky is insufficient. The cherry-pick forgot to
handle APIMockTestCase as the corresponding code is different
between the master branch and stable/rocky branches and
as a result APIMockTestCase in stable/rocky branch does not
monkey-patch django.contrib.auth.middleware.

Related-Bug: #1806053
Change-Id: I4993ff5006b6366df64b6d96acddf15be0cc331c

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I894b54502150c0d6ed4783b1deacaf225b927af8

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ide9dc8de44567ff8839d367f0ffaf9fde92b6ea4

When uploading an image, if we do not set a minimum ram and disk size we
try to send "None" to glance.
We should instead send "0" and glance will calculate the size from the
provided image.

Change-Id: Ia1aeabcdcf021943ebb7a4e35939c383ac820b19
Closes-Bug: #1809121
(cherry picked from commit 65b21e7f)

This patch rollbacks changes in APITestCase introduced in the
0d163613 commit to unblock Horizon
plugins gates.

Change-Id: I6b2be31568e4aa4273990f9cfa76ca139620c84b
Closes-bug: #1806053
Closes-bug: #1805240
(cherry picked from commit de69edd0)

The latest selenium webdriver fails with old geckodriver.

This patch also fixes horizon-selenium-headless job.

Change-Id: I8dfdc7e80dfe680d6699fc7f1f8325b85a9f7c8f
(cherry picked from commit e3bfad6a)

Closes-Bug: #1806621

Change-Id: Ice5b56777967566770454bfbd6800bf3b8c57a37
(cherry picked from commit f8eb17c5)

Change-Id: Ia6b1c99c277c4cd5b19deae5212c7806b4b06a23
Closes-Bug: 1791043
(cherry picked from commit 71be92dd)

If you're a user without administrative permissions, you will
not be able to edit a password using the table inside the identity
section due to the fact that it uses a different edit API which
is not meant to be used for the user-side of things.

This patch adds a policy change in order to hide the change password
link for normal users, while keeping the functionality inside
the Settings panel still intact.

This change was first broken by I76eb9f95c7112bcbad75ee151f363f892298d081

Partial-Bug: 1788384
Change-Id: I7a64257ac274c9dac5705ba72a85833f8e7a1591
(cherry picked from commit 0630be63)

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I29a8bc8f538ba7bb48e6fb7754b5c7a530d4ff00

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: If9d6453dbe03415efbe1fef3a44611f192f0ab09

Glance project has a blueprint hidden-images. The commit can be
seen from https://review.openstack.org/#/c/578755/
The os_hidden is added into image metadata as bool type. From
horizon, the string value of os_hidden is passed to glanceclient.
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/images.py#L341
But type is not correspond so raise exception to horizon from
glanceclient.

Here to change the type of os_hidden before passing it to glanceclient.

Closes-Bug: #1789172
Change-Id: I0d4edaa4b661d2da79cdb45e4afa97d826aeb65d
(cherry picked from commit 47ba614f)

The "request" attribute is not available in
openstack_auth.backend.KeystoneBackend.get_user when session data is restored
and it's the first request to happen after a server restart.

As stated by the function document, the "request" attribute needs to be
monkey-patched by openstack_auth.utils.patch_middleware_get_user
for this function to work properly.

This should happen in openstack_auth.urls at import time. But there is nowhere
in Horizon where this module is imported at startup. It's only introspected
by openstack_dashboard.urls due to AUTHENTICATION_URLS setting.

Without this monkey-patching, the whole authentication mechanism falls back
to "AnonymousUser" and you will get redirected to the login page due
to horizon.exceptions.NotAuthenticated being raised by
horizon.decorators.require_auth as request.user.is_authenticated will be False.

But if a user requests a page under auth/, it will have the side-effect of
monkey-patching django.contrib.auth.middleware as expected. This means that
once this request is completed, all following requests to pages other than
the ones under auth/ will have there sessions properly restored and
you will be properly authenticated.

Therefore this change introduces a dummy middleware which sole purpose is
to perform this monkey-patching as early as possible.

There is also some cleanup to get rid of the previous attempts at
monkeypatching.

Closes-bug: #1764622

Conflicts:
	openstack_dashboard/settings.py
	openstack_dashboard/test/helpers.py

Change-Id: Ib9912090a87b716e7f5710f6f360b0df168ec2e3
(cherry picked from commit 0d163613)

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I39a97be850e4123dee0da9deec74dd1c04e74a1f

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ibb7663f621eb1564755d12aa9bacfd3a52ecd3c6

The original code is monkey-patching keystoneclient object to add a
user_id attribute to it. This no longer works with more recent
versions of keystoneclient, as they wrap the client in a helper
class.

I'm not happy with this solution, it's likely to have side effects
and to break again. I'm putting it up for discussion for a better
solution.

Change-Id: Idb296d1b10fa02a0b4852e96fe8cb2bdd70380e0
Closes-bug: #1776678
(cherry picked from commit bdb3f9d9)

Add a new optional WEBSSO_KEYSTONE_URL property to facilitate WEBSSO
deployments where network segmentation is used per security requirement.
In this case, the controllers are not reachable from public network.
Therefore, user's browser will not be able to reach OPENSTACK_KEYSTONE_URL
if it is set to the internal endpoint.

If WEBSSO_KEYSTONE_URL is set, it will be used instead of
OPENSTACK_KEYSTONE_URL.

Change-Id: I05ea4227aa4c2cb0a73015ed7fd29cf1a96e696a
Closes-bug: #1544703
(cherry picked from commit a53f012f)

* Fix release version name(latest->rocky)
* Fix list number(trivial)

Change-Id: Iba509025d99ac89e467f0a3b6ee92d93258499f7

If enable_backup is False in OPENSTACK_CINDER_FEATURES
then we should not display the backups panel.

Change-Id: I276eebf0f11406bf354f5d8bbecef7b244d6d340
Closes-Bug: #1778771
(cherry picked from commit 6c2225ba)

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I3b48f05cd994777d855ad7f80ca70a2672edd3e3

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ic2c52f38cbbf45062f55d5bad504efd857ba1741