Change-Id: I7964252f9d65b17915ac1d324b186955213a6297

Change-Id: I5106499e5d0f90fe02c07a7668d810a0a97822aa

When ceph-proxy is configured prior to being related
to clients, it is possible for the units to go into
a hook error because of an undefined variable. This
change ensures that we do correctly define the unit
before we use it.

Change-Id: Ic6e28783bde4fc342d7c5ef1d733e69a03b702fe
Closes-Bug: #1862487

Change-Id: Ib2e4cb4f12c1d0868af73c8b690b7cd5ebff76c2

Change-Id: I7587becc363365b7fff1d74b678e917bb27ea2b5

Change-Id: Id61c1806a17a76c45e3dc19f1d97c250cc6125b8

This patch also updates the smoke test to run bionic-train.

Change-Id: I0ba45f400cde80ab4ec86e7ceb88dea786c74c82

Also clean up pre-existing pep8 violations in the
files/* dir which was previously not covered by lint testing.

Also clean-up mocking issues around apt-pkg replacements in the
unit tests.

Also fix py35 issue with enabled_manager_modules() function in the
charmhelpers library (see
https://github.com/juju/charm-helpers/pull/387).

Also fix the functional tests bundles so they actually test the
version of OpenStack that the bundle indicates.

Change-Id: I2c8d84fadc11311c622dd308c4694496872dc157

Added cinder-ceph to CI to run a new functional
test included in zaza.

Change-Id: I3a91ff4cc55edd824501d0e190cc239ae03f54a5

Currently add-permissions-to-key requests are not being handled by this
charm, so if cinder-ceph or glance is deployed with
restrict-ceph-pools=True, it will not be configured properly. This
patch ports the implementation of the add-permissions-to-key
handling from the ceph-mon charm, and updates other methods required
to properly set up cinder-ceph and glance ceph pools.

Change-Id: If5950af155e10ee4d140300fd7ed5730798b65f0
Closes-bug: #1836408

The charm was incorrectly pulling in an old branch of zaza, this
change points it back at master.

Change-Id: I2a98f843c54f883782e4911412b45185996ce038

Tests.yaml was missing a parameter, causing
zaza to pull latest ceph-proxy from charm
store instead of using the changes of
patches proposed in gerrit.

This change fixes it, now zaza deploys
ceph-proxy from local repo created
during tests that contains the patch
proposed in gerrit.

Change-Id: I3681e72f032780b864d02a95cf983f26a0b1c91e

The bundle disco-stein was in the dev bundles because
a bug with the Python 3.7 syntax prevented the success of
the deployment of HA clusters. This bug is fixed, we can
reintegrate disco-stein in the gate bundles.

Other small additions:
- Passing OS env vars instead of AMULET
- removing sitepackages in tox.ini to avoid test env pollution
- skip_missing_interpreters in tox.ini set to False to avoid false
positives by skipping missing interpreters.
- adding bionic-stein bundle to gate_bundles instead of dev

LP Related-Bug: #1823718
Change-Id: Ia7093a5654a763670be05635f7f6fce292eb9c96

Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata.  Dev release tests are enabled separately
because of chickens and eggs.

Change-Id: Ie306d2caaafb16eff0ee4481a691c1f5a2f31cf4

This is a mechanically generated patch to ensure unit testing is in place
for all of the Tested Runtimes for Train.

See the Train python3-updates goal document for details:
https://governance.openstack.org/tc/goals/train/python3-updates.html

Note that python35-charm-jobs is retained since this charm is supported
on Xenial.

Change-Id: Ib39664a09e76cb5a3f764057b42d5cd33c1f8f75
Story: #2005924
Task: #34228

Change-Id: I759be5dc13a784efe5850c403275c2c0b288da13

Change-Id: If9e79b22a919997961a23929435450af0883b882
Closes-Bug: #1828424
func-test-pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/5

This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.

Drop explicit install of python-ceph; ceph-common has an
appropriate dependency on the required python{3}-ceph package
so this is not required, and breaks on Stein where Python 2
packages are no longer provided.

Closes-Bug: 1824154
Change-Id: Ia219258f73f038170bc5a070d562e499459fe246

Change-Id: If730e91a5e15fb1279024af4562d99a942cd7348

Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata.  Dev release tests are enabled separately
because of chickens and eggs.

Change-Id: I30800945c7799727f19731f04b61972148df830c

As a part of the Stein release, we need to ensure
that charmhelpers is up to date.

Change-Id: I53f388a0371b09bacd10122351f060a5a131947b

* Move charmhelpers to the root of the charm
* sync charmhelpers to latest version

Change-Id: Id0b838f0206635cf912d205f2fb6fda7b31d0dfe

A system upgrade broke ostestr. We can fix it by just calling stestr
directly.

Change-Id: I238730d47f05ec18cc1efd7ab20b88a8c29a2858

Using the new version of the sync tool which removes the charmhelpers
directory before syncing, run charm helpers sync to find any unexpected
missing dependencies.

Change-Id: Ifa5ba56af4b120903c2cc3822834c4279cd56acc

The pre-install operations may fail, yet that failure is not
elevated to the user. This masks the failure and makes early
package install issues difficult to troubleshoot.

If the basic pre-install script fails, the charm should not
proceed to later hooks as the requirements may not be met.

Hashbangs for bash should specify -e (errexit) on all of the
pre-install bash scripts.

Change-Id: I97e2d9fa092fd6af5f426977cf99ab735e520496
Closes-bug: #1815243
Partial-bug: #1815231

Remove trusty-icehouse test combo from gate, leaving trusty-mitaka
if/where it exists.

Change-Id: I12fb4a889e5358aac76e8c7d8f1663976e2b7185

Also, this change removes the harden decorators as
the required configuration for harden is _not_ present
in the charm config, rendering it useless.

Change-Id: I20c124d9588b8fd6c0e6611725a848eaf892f6af
Closes-Bug: #1812219

Change-Id: Ib93a16da251c359cfb19cd1119c9ca60cfbdc2f2

Change-Id: Iaa29be49b44c76c4c89cef17b3212502b09d65ac

The tests/charm-helpers contents were removed in the last cycle
but the corresponding sync tool was not updated for this charm.

Change-Id: I06fc6263ba31f7e37b45b1bd0af658bcd602254d

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I376bcfa0b37407876609f1183ecb72b614160457
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: Ibccf221d130703949f5538d061cb3eb4f44eb677

Change-Id: I2018de28dc4a3767af91a76b9ad8dd1175bec513