From trusty onwards apache 2.4 is installed. The charm no longer needs
to check for apache 2.2 configurations.

This also solves Bug #1799500 where a package like javascript-common
pre-creates the /etc/apache directory leading to a failed
register_configs.

Note: The previous fix for Bug #1799500 was incorrect.
Reverting and adding a set -e to avoid future breakage.

This will need to be backported to stable.

Change-Id: Ic6025bd10568a748e39faaf3a97b4b6a2c35a4d2
Closes-Bug: #1799500
(cherry picked from commit e9caae0a23461f3b503035e94865ccc3c8509a32)

Due to a change to PY3, the charmhelpers directory is not in the
CHARMDIR rather than in CHARMDIR/hooks. This broke the
copy_nrpe_checks() function in c-h. c-h has been updated, to look in
both CHARMDIR and CHARMDIR/hooks for the charmhelpers directory, and
this patchset includes the new function definition.

Change-Id: I583b7acbffb5560aba8313d30da77f4d8073ba9b
Closes-Bug: #1796830

Set default branch for git review/gerrit.

Switch amulet tests to stable.

Switch to using stable charm-helpers branch.

Change-Id: I0c2dff58ed63208fe346c3372cc1ea0079e4649c

On charm upgrade the charm may switch to py3 packages. If so, ensure
the old py2 packages are purged. If the purge occurs then restart
services.

Change-Id: I473ed1da342b2294f0f66f836b40387c1f831f5c
Closes-Bug: 1803451

Change-Id: Ie65865c0965e94d6c41b425a3a8a6cb6142d2d05

Change-Id: Ie413b2fed14f7aa7fd9abdd4ff77c2d111238856

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I731b0717ad6aa9c0b9f4ce193300ded79671c7aa
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: I74930cf363fe652a34d7ad86cdc493b15557ed40
Closes-Bug: #1799877

Apache2 is a dependency of openstack-dashboard which gets installed in
the install() function. However, prior to that we register configs
which does a check of the apache2 package version leading to a chicken
and egg race.

Pre-install apache2 in the bash install script to avoid this race.

Closes-Bug: #1799500

Change-Id: I1f73a6b0284ca4e0a4018bff73fd4f8a778c4db5

Charmhelpers is now installed via pip for unit tests so stop
'Make sync' from pulling it down.

Change-Id: I88d70579a904b88d037a8fb282a1f79203073b5a

Install the neutron-fwaas-dashboard package at Rocky; this is the
first release that this dashboard is packaged for and co-incides
with the switch to using Python 3 for Horizon itself.

Change-Id: I0522bd20b8f6f707c3f69b88313d9b0aa129af07

Switch package install to Python 3 for OpenStack Rocky or later.

When upgrading, remove any python-* packages that where explicitly
installated and then autoremove --purge any dependencies that are
no longer required.

Change-Id: I1355382846aeb6d0ad29be32b9e6fcf47d318290

Also remove tests/charm-helpers if present, in favor
of the pip-installed charm-helpers.

Change-Id: I304d555dcbd86c75b8d84cb376ff4112bfbe0d68

This change upgrades the charm to PY3 only mode.
Note the changes to charm-helpers has also been made to support
Apache auditing code in PY3.

Change-Id: Idd347de5818ec57cb05f38170fe0d6536157a0da

Implement the series-upgrade feature allowing to move between Ubuntu
series.

Change-Id: I5ae677ece057ede71b227309eea0d1b635d55f7b

Add a tactical change which is already merged into charm-helpers.

This needs to go into all charms to solve the chicken:egg issue
where cosmic is untestable until this change exists.

Reference:

https://github.com/juju/charm-helpers/commit/4835c6c167c429527ef0a0291d17cf559c9cf880

Change-Id: I7c775abf0172bb17e047542c8b1fc728c56bdfe5

This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Id37b5d71689b61d43c7aa80249e61c0659f7a0bc
Story: #2002586
Task: #24317

Change-Id: I29be2410d2880ec7f281a9f1f1613c767aa458fb
Closes-bug: #1791260

Update testing setup and config.
Fixes to policy.json

Closes-Bug: #1789961
Change-Id: Iac5da7cd02a5c87f3002dbabf6c21a5c2f936536

Change-Id: I2fd2188572dd7838ec066c810f6882e9274d25a5

Add support for the dashboard to request and receive certificates
via the certificates relation, currently implemented by vault.

The first request to the dashboard can take sometime to return
so increase the timeout.

Change-Id: I173523ddbe3269e3fcdae49062cdb34e78786e44

Change-Id: Ibd54b4a4e98caf5590f1a147de6b15c2dabf5849

Adds a setting custom-theme which operats similar to ubuntu-theme and
default-theme. The provided resource is placed in the themes folder and
apache is setup to serve static content for the theme. This leaves the
default theme untouched allowing the custom theme to override files
based on the built in horizon theme capabilities. For details on theming
capabilities see:
https://docs.openstack.org/horizon/latest/configuration/themes.html

gnuoy: retry logic for unrelated test updated after a number of CI
failures.

Closes-Bug: #1778284

Change-Id: I91ad19e8aad5c0e0773d42fa4f085cbcecb82458

Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata.  Dev release tests are enabled separately
because of chickens and eggs.

Change-Id: I1e0b7d0d0994fd229c15cf8c456b2b82bc4041e8

In clouds with many containers or objects, listing them via Horizon
can cause a signficant increase of system load.

This patch enables configuration of the API_RESULT_LIMIT setting within
Horizon. This limits the maximum number of objects to display on a
single page before providing a paging element to paginate results.

Change-Id: Ifaf39d6c9bf549428afd7653243c82cd719956f6
Closes-Bug: 1775002

Python 3.6 is installed by default in Ubuntu 18.04 LTS.
Therefore, according to Transition Plan [1],
it'll be handy to have py36 testenv.

For more details, please check Python2 Deprecation Timeline [2]
and Python3-first Goal - Completion Criteria [3].

[1] https://wiki.ubuntu.com/Python/Python36Transition
[2] https://governance.openstack.org/tc/resolutions/20180529-python2-deprecation-timeline.html
[3] https://review.openstack.org/#/c/575933/8/goals/stein/python3-first.rst@42

Change-Id: Iae9e7269e4b70da56c3a8c025b6cc48566be0d0f

`syncdb` subcommand was deprecated in django 1.7
and subsequently removed in 1.9.

Use `subprocess.check_call()` so we catch errors.

Add `shared-db` relation and enable debug logging in deployment
used in functional test.  Add functional test that authenticates
through the dashboard.

Update unit tests.

Change-Id: I567461e57ec431fc470d7a2a31d3f16e9dc50e8b
Closes-Bug: #1777358

There is a eluding issue that currently makes the
first request to the OpenStack Dashboard error out
with 500 Internal Server Error in CI.  Temporarilly
add retry logic to unwedge the gate.  This issue
should be revisited and root caused properly when time
allows.

Change-Id: Id828082416c7cbdd88247d9b6750c0f77467bc26

Change-Id: Ib15aa2d76e009415f525132492bcc3679750bfd9

The horizon interface enables/displays actions based on the
keystonev3_policy.json file provided. The keystonev3_policy.json file
included by the charm has rules for various actions that depend on the
target object's domain id (user, group, project). The buttons displayed
for creating and deleting the objects (shown above the tables) are also
based on these policy rules but no target object exists because they are
bound to the table and not a specific target object.

This patch changes some of the policy rules to create/delete users,
projects, and groups to not require the target object's domain_id. This
is safe to do because the table is shown within the context of the
target domain_id already. Additionally, the actual ability to alter
objects is controlled by the actual policy installed in Keystone and not
the Horizon UI.

Without this change, actions such as "Create User" will only show for
a user who is a cloud admin and not for any domain admins (even if the
domain admin is allowed to perform the action via the API or CLI).

Change-Id: Ie0a85e11e6a171083deb19b0eb26c7e552390c00
Closes-Bug: #1775224
Closes-Bug: #1775229

Support for dfs was dropped in commit b4019e45

Remove orphan symlink in the actions/ directory.

Change-Id: Ie353de9da422a863e53a92983d9819c324761667